stargate icon indicating copy to clipboard operation
stargate copied to clipboard

C2-1024 Support Protocol V5

Open maheshrajamani opened this issue 3 years ago • 1 comments

What this PR does:

Which issue(s) this PR fixes: Fixes #770

Checklist

  • [ X] Changes manually tested
  • [ ] Automated Tests added/updated
  • [ ] Documentation added/updated
  • [ ] CLA Signed: DataStax CLA

Yet to add integration test cases.

maheshrajamani avatar Aug 25 '22 12:08 maheshrajamani

  • Make sure that the existing CQL integration tests work with the java-driver using protocol v5
  • Explicitly test that the result metadata ID stuff works with all the backends
  • It may not be possible to support v5 with all backend and in that case we may need to dynamically configuration the highest supported protocol version based on the persistence backend
  • We may need to support system.peers_v2 some drivers expect that when using v5 or if release_versions >= 4.0.0
  • I would go through each v5 protocol feature an make sure that it's supported (per query/execute/prepare keyspaces, the duration type, etc.)

mpenick avatar Aug 25 '22 18:08 mpenick

@maheshrajamani can you rebase this? Hope it is not too much of a pain due to coordinator directory change. Then we will ask DB team for review

jeffreyscarpenter avatar Jun 02 '23 14:06 jeffreyscarpenter

@maheshrajamani can you rebase this? Hope it is not too much of a pain due to coordinator directory change. Then we will ask DB team for review

@jeffreyscarpenter These changes were done with copying code from cassandra 4.0.3 code base. Better to be redone using 4.0.10 cassandra code base (this is the current dependency). There shouldn't be much difference.

maheshrajamani avatar Jun 02 '23 14:06 maheshrajamani

Closing this PR, as per conversation above we will start over with newer C* version.

jeffreyscarpenter avatar Jun 05 '23 22:06 jeffreyscarpenter