starcoin icon indicating copy to clipboard operation
starcoin copied to clipboard

Add gas token to transaction options

Open sanlee42 opened this issue 2 years ago • 3 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

sanlee42 avatar Oct 11 '22 13:10 sanlee42

Codecov Report

Merging #3780 (8041817) into master (a80c83a) will increase coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3780      +/-   ##
==========================================
+ Coverage   53.58%   53.62%   +0.04%     
==========================================
  Files         594      594              
  Lines       64148    64152       +4     
==========================================
+ Hits        34366    34393      +27     
+ Misses      29782    29759      -23     
Flag Coverage Δ
unittests 53.62% <0.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/cli_state.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/view.rs 0.00% <0.00%> (ø)
network-p2p/src/discovery.rs 72.09% <0.00%> (-0.12%) :arrow_down:
network-p2p/src/request_responses.rs 83.81% <0.00%> (+0.38%) :arrow_up:
...rc/protocol/generic_proto/upgrade/notifications.rs 90.89% <0.00%> (+0.54%) :arrow_up:
sync/src/tasks/mod.rs 79.12% <0.00%> (+0.89%) :arrow_up:
sync/src/tasks/mock.rs 89.07% <0.00%> (+2.43%) :arrow_up:
network/api/src/peer_provider.rs 53.94% <0.00%> (+2.92%) :arrow_up:
network-rpc/core/src/lib.rs 36.07% <0.00%> (+4.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a80c83a...8041817. Read the comment docs.

codecov[bot] avatar Oct 11 '22 13:10 codecov[bot]

Benchmark for 538e406

Click to view benchmark
Test Base PR %
accumulator_append 604.3±10.53µs 608.7±28.19µs +0.73%
block_apply/block_apply_10 845.0±1.79ms 843.6±3.27ms -0.17%
block_apply/block_apply_1000 85.6±0.06s 85.2±0.10s -0.47%
get_with_proof/db_store 36.9±0.53µs 36.5±0.23µs -1.08%
get_with_proof/mem_store 31.8±0.24µs 31.7±1.02µs -0.31%
put_and_commit/db_store/1 96.0±5.06µs 96.1±4.93µs +0.10%
put_and_commit/db_store/10 859.7±41.36µs 859.7±40.89µs 0.00%
put_and_commit/db_store/100 7.3±0.31ms 7.4±0.28ms +1.37%
put_and_commit/db_store/5 442.8±24.92µs 416.8±21.43µs -5.87%
put_and_commit/db_store/50 3.9±0.17ms 3.8±0.17ms -2.56%
put_and_commit/mem_store/1 61.7±5.65µs 61.9±5.70µs +0.32%
put_and_commit/mem_store/10 577.2±46.89µs 577.1±47.63µs -0.02%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 293.1±25.62µs 292.1±24.45µs -0.34%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 6.7±0.26ms 6.7±0.36ms 0.00%
query_block/query_block_in(10)_times(1000) 66.6±1.78ms 68.4±3.30ms +2.70%
query_block/query_block_in(10)_times(10000) 667.1±18.69ms 672.1±22.44ms +0.75%
query_block/query_block_in(1000)_times(100) 1001.7±7.46µs 978.0±12.71µs -2.37%
query_block/query_block_in(1000)_times(1000) 10.1±0.10ms 9.8±0.16ms -2.97%
query_block/query_block_in(1000)_times(10000) 101.6±1.58ms 98.5±0.73ms -3.05%
storage_transaction 1061.4±275.34µs 1060.5±269.92µs -0.08%
vm/transaction_execution/1 953.8±3.15ms 951.1±1.95ms -0.28%
vm/transaction_execution/10 237.2±1.20ms 236.9±1.19ms -0.13%
vm/transaction_execution/20 202.6±0.61ms 204.0±2.50ms +0.69%
vm/transaction_execution/5 313.3±0.81ms 313.8±1.33ms +0.16%
vm/transaction_execution/50 218.6±0.51ms 219.0±1.40ms +0.18%

github-actions[bot] avatar Oct 11 '22 14:10 github-actions[bot]

Benchmark for 5e7b068

Click to view benchmark
Test Base PR %
accumulator_append 609.0±13.38µs 604.4±29.22µs -0.76%
block_apply/block_apply_10 843.2±6.66ms 840.8±1.32ms -0.28%
block_apply/block_apply_1000 85.0±0.13s 85.3±0.04s +0.35%
get_with_proof/db_store 36.6±0.25µs 36.1±0.51µs -1.37%
get_with_proof/mem_store 31.4±0.13µs 31.5±0.24µs +0.32%
put_and_commit/db_store/1 95.3±4.77µs 96.0±4.70µs +0.73%
put_and_commit/db_store/10 856.5±38.54µs 859.9±39.28µs +0.40%
put_and_commit/db_store/100 7.3±0.30ms 7.3±0.30ms 0.00%
put_and_commit/db_store/5 435.5±21.41µs 440.9±20.96µs +1.24%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.63µs 61.6±5.64µs +0.16%
put_and_commit/mem_store/10 574.8±47.03µs 574.5±46.04µs -0.05%
put_and_commit/mem_store/100 5.7±0.84ms 5.6±0.34ms -1.75%
put_and_commit/mem_store/5 290.3±24.49µs 290.3±24.61µs 0.00%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 6.7±0.40ms 6.5±0.20ms -2.99%
query_block/query_block_in(10)_times(1000) 66.3±2.88ms 66.8±2.70ms +0.75%
query_block/query_block_in(10)_times(10000) 656.4±23.61ms 662.5±17.93ms +0.93%
query_block/query_block_in(1000)_times(100) 999.2±7.85µs 1007.8±18.65µs +0.86%
query_block/query_block_in(1000)_times(1000) 10.0±0.12ms 10.1±0.19ms +1.00%
query_block/query_block_in(1000)_times(10000) 100.2±0.91ms 101.6±1.15ms +1.40%
storage_transaction 1056.5±271.10µs 1056.4±267.44µs -0.01%
vm/transaction_execution/1 949.9±4.24ms 946.4±2.50ms -0.37%
vm/transaction_execution/10 236.8±3.02ms 235.9±2.01ms -0.38%
vm/transaction_execution/20 202.3±1.01ms 202.2±2.25ms -0.05%
vm/transaction_execution/5 313.4±1.31ms 312.7±2.22ms -0.22%
vm/transaction_execution/50 218.5±1.64ms 217.4±0.89ms -0.50%

github-actions[bot] avatar Oct 12 '22 02:10 github-actions[bot]

Benchmark for 66c38dd

Click to view benchmark
Test Base PR %
accumulator_append 606.4±31.51µs 603.4±28.62µs -0.49%
block_apply/block_apply_10 835.3±1.01ms 837.6±2.12ms +0.28%
block_apply/block_apply_1000 84.5±0.06s 84.7±0.06s +0.24%
get_with_proof/db_store 36.4±0.35µs 36.5±0.22µs +0.27%
get_with_proof/mem_store 31.3±0.39µs 31.5±0.30µs +0.64%
put_and_commit/db_store/1 95.4±4.82µs 96.7±4.61µs +1.36%
put_and_commit/db_store/10 866.9±40.13µs 855.9±39.07µs -1.27%
put_and_commit/db_store/100 7.3±0.30ms 7.3±0.30ms 0.00%
put_and_commit/db_store/5 435.8±21.40µs 436.0±20.36µs +0.05%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.7±5.63µs 62.1±5.69µs +0.65%
put_and_commit/mem_store/10 577.2±47.17µs 576.2±46.75µs -0.17%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 290.5±24.75µs 293.4±25.62µs +1.00%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 6.7±0.19ms 6.9±0.26ms +2.99%
query_block/query_block_in(10)_times(1000) 68.1±1.24ms 67.6±2.71ms -0.73%
query_block/query_block_in(10)_times(10000) 685.5±23.54ms 672.0±11.21ms -1.97%
query_block/query_block_in(1000)_times(100) 994.0±13.87µs 997.8±8.28µs +0.38%
query_block/query_block_in(1000)_times(1000) 10.0±0.11ms 10.0±0.14ms 0.00%
query_block/query_block_in(1000)_times(10000) 99.5±1.28ms 99.1±1.19ms -0.40%
storage_transaction 1071.7±301.13µs 1082.3±346.93µs +0.99%
vm/transaction_execution/1 950.8±3.67ms 946.3±2.34ms -0.47%
vm/transaction_execution/10 240.1±0.67ms 238.2±0.50ms -0.79%
vm/transaction_execution/20 206.5±0.67ms 206.0±4.17ms -0.24%
vm/transaction_execution/5 316.0±0.86ms 315.1±1.57ms -0.28%
vm/transaction_execution/50 222.6±0.62ms 220.4±0.65ms -0.99%

github-actions[bot] avatar Oct 20 '22 19:10 github-actions[bot]