starcoin-framework
starcoin-framework copied to clipboard
bug: DAOSpace MemberProposalPlugin execute_proposal with empty image_data cause join_member fail
Bug Report
Starcoin Framework version:
commit_id: 4ebe51bc86b82001f8ed04dadd51ffea47d73824 branch: main
Current behavior:
Create a proposal for adding members. If the incoming image_data is an empty string, it will cause the proposal to fail to add members after the proposal is voted successfully. Error: ERR_CANOT_EMPTY
Expected behavior:
After the proposal is voted successfully, members are added successfully.
Steps to reproduce:
call 0x1::MemberProposalPlugin::create_proposal_entry
params: [
$daoType,
'Apply add 0x76Ac08692318fd25E2E5e5c37662530B as member',
'0x76Ac08692318fd25E2E5e5c37662530B',
"",
"ipfs://xxxxxx",
100,
0
]
Related code:
https://github.com/starcoinorg/starcoin-framework/blob/4ebe51bc86b82001f8ed04dadd51ffea47d73824/sources/daospaceplugin/MemberProposalPlugin.move#L73
Other information:
Detail Error:
ALERT: Starmask: contract.dry_run_raw failed. Error: {"MoveAbort":{"abort_code":26631,"explain":{"category_code":7,"category_name":"INVALID_ARGUMENT","reason_code":104,"reason_name":"ERR_CANOT_EMPTY"},"location":{"Module":{"address":"0x00000000000000000000000000000001","name":"NFT"}}}}