coronaqr icon indicating copy to clipboard operation
coronaqr copied to clipboard

implement covid business rule verification

Open stapelberg opened this issue 2 years ago • 5 comments

I have a pending commit which passes all the test cases.

What’s missing is a good source for country rules. I asked around regarding sources in https://github.com/eu-digital-green-certificates/dgc-participating-countries/issues/10#issuecomment-891236663

stapelberg avatar Aug 02 '21 18:08 stapelberg

I could give you the Belgian rules if you want :)

demobiel avatar Aug 03 '21 15:08 demobiel

Thank you for the offer! Are you talking about a publically accessible Belgian rule source that the coronaqr package/program could query? We need a live source, not a one-time snapshot for any country’s rules to be useful :)

stapelberg avatar Aug 03 '21 15:08 stapelberg

If you want I commit to provide that resource. In what format should it be delivered?

At the moment these are the rules: If you are vaccinated twice, you are allowed if your last vaccine was 2 weeks ago If you have a negative CRT test, you are allowed up to 48h after the certificate has been issued If you have a negative RAT test, you are allowed up to 24h after the certificate has been issued If you have a "recovery certificate" you are allowed it is was issued 11 days ago, but not longer than 180 days after your positive CRT test.

demobiel avatar Aug 04 '21 15:08 demobiel

The format is certlogic as specified in https://github.com/ehn-dcc-development/dgc-business-rules, see https://github.com/eu-digital-green-certificates/dgc-business-rules-testdata/blob/main/FR/VR-FR-0004/rule.json for an example from France.

The Belgian government is supposed to provide these rules expressed in certlogic somewhere, if I understand correctly. Do you have a Belgian open-source corona app? That would be a good place to check first.

I don’t see a BE directory in https://github.com/eu-digital-green-certificates/dgc-business-rules-testdata yet, which is a bit surprising. Perhaps whoever is responsible for maintaining the Belgian certlogic rules can submit them into the dgc-business-rules-testdata repository as a pull request?

stapelberg avatar Aug 04 '21 15:08 stapelberg

no there is no open source app, only an APK to download, but not much info to find in there when I tried to extract it:

https://apkcombo.com/nl/apk-downloader/?q=be.fgov.ehealth.DGC.scan

I am in contact with "Digitaal Vlaanderen" who is responsible for developing the app, and I can ask them if I can get the rules.

demobiel avatar Aug 04 '21 16:08 demobiel