Michael Stapelberg

Results 648 comments of Michael Stapelberg

I don’t understand what the problems are. At the very minimum, please always include a standalone program that illustrates what the problem is. You might have to dig into the...

Thanks, looks like a good first start. Let me know once this is ready for review

Sounds good to me!

The `UserData` field was last touched in commit 0b3d8b56f6af673267457b98226f6659773ae6f7 by @sbezverk — any comments on this?

Linux 3.10 is pretty old. There may well be kernel bugs or changes that you’re running into. Is CentOS one of the distributions that ships a heavily modified kernel? Might...

Regarding the `String()` method, just to double-check: it would return a human-readable representation of the rule, and wouldn’t be used programmatically, yes? If so, that seems okay to me.

Sure, in that case adding String() makes sense. For the other methods, I’m tentatively in favor, but let’s discuss those over a pull request maybe? In general, this library is...

Hey! Here’s a few pointers: 1. You can work in a network namespace to play around with `nft` without any consequences for your host system: ``` # ip netns add...

Disclaimer: I haven’t thought much about how a good abstraction layer would look like. To me, an important question that I can’t answer yet, is whether the ideal abstraction would...