muffon icon indicating copy to clipboard operation
muffon copied to clipboard

Add preview on taskbar icon hover

Open sstvskids opened this issue 1 year ago • 14 comments

Example: image

This would be useful to creators and help them out alot.

sstvskids avatar Jan 03 '24 19:01 sstvskids

Hmm, interesting. @staniel359 @gamersi what do you think?

My 2 cents, this’ll not be that good. We can’t implement the play button or next or previous. Because, you are not supposed to play different tracks from different tabs simultaneously.

It’ll be just the preview of the tab if this is implemented, the preview will only show what you’d see once you open the tab.

xyloflake avatar Jan 04 '24 04:01 xyloflake

Hey @staniel359 @gamersi you forgot about this.

xyloflake avatar Jan 05 '24 23:01 xyloflake

Yeah with the tabs it will get pretty messy

gamersi avatar Jan 05 '24 23:01 gamersi

@sstvskids Hello. Thanks, added to planned.

@xyloflake @gamersi That's techically feasible: https://www.electronjs.org/docs/latest/tutorial/windows-taskbar#thumbnail-toolbars

Also keyboard player controls work now, you can check yourselves.

staniel359 avatar Jan 06 '24 09:01 staniel359

@staniel359 it's not about doable or not. It's about should you do it? IMHO it would make things messier.

xyloflake avatar Jan 08 '24 21:01 xyloflake

@xyloflake Why? It'll look like a Windows media player.

staniel359 avatar Jan 08 '24 21:01 staniel359

@xyloflake Why? It'll look like a Windows media player.

what if someone has multiple songs playing in different tabs?

gamersi avatar Jan 08 '24 21:01 gamersi

@staniel359 sorry, I misunderstood this as implementing tab preview for muffon tabs, not windows tabs.

xyloflake avatar Jan 08 '24 21:01 xyloflake

@gamersi

what if someone has multiple songs playing in different tabs?

Then active tab's audio will be controlled.

staniel359 avatar Jan 08 '24 21:01 staniel359

@staniel359 I and @gamersi have tried really hard but the method from the electron docs doesn't work. At all.

xyloflake avatar May 03 '24 02:05 xyloflake

@xyloflake Have you tested with a packaged app?

staniel359 avatar May 03 '24 07:05 staniel359

@staniel359 I think we didn't iirc. @gamersi can you try a packaged app?

xyloflake avatar May 03 '24 07:05 xyloflake

I tried

gamersi avatar May 03 '24 07:05 gamersi

@staniel359 nope it 100% doesn't work.

xyloflake avatar May 03 '24 08:05 xyloflake