Stan Hu
Stan Hu
@dblock Thanks. The problem is that I'd have to do something like that for every Array type, and it's easy to miss. This is how I dealt with this automatically:...
https://github.com/awslabs/amazon-eks-ami/pull/898 updates this pull request to work on `master`.
It seems https://github.com/aws-samples/amazon-eks-custom-amis/blob/10a7d51686982cb67f7695f72cac74e41eaa7eed/files/functions.sh#L459-L481 might already do this for RHEL.
I've reproduced the problem with `sassc` as well: ``` $ bin/sassc /tmp/fail.txt Error: 1fr/repeat isn't a valid CSS value. on line 7049 of ../../../../tmp/fail.txt >> grid: 1fr/repeat(2, 1fr); } --------^...
It looks like `1fr/repeat(2, 1fr)` doesn't work, but `1fr / repeat(2, 1fr)` does: Sample input: ```css .grid-layout2 { grid: 1fr/repeat(2, 1fr); } ```
@michael-grunder I think we can close this in favor of #81.
I'm going to abandon efforts on this since redis-client fixes all the issues I identified with hiredis-rb: https://github.com/redis/hiredis-rb/issues/58#issuecomment-1211033335
Closing because redis-rb v5.0 will have hiredis support, and this pull request would need changes for redis-rb in any case.
Some work towards this: 1. https://github.com/redis/hiredis-rb/pull/87 2. https://github.com/redis/hiredis/pull/1085
It seems redis-client already supports SSL with hiredis: https://github.com/redis-rb/redis-client/blob/master/hiredis-client/ext/redis_client/hiredis/hiredis_connection.c I wonder if we should just deprecate this library in favor of that.