dspy icon indicating copy to clipboard operation
dspy copied to clipboard

fix: Enable pre-commit CI workflow on pull requests

Open ulgens opened this issue 1 year ago • 8 comments

Enables precommit_checks CI workflow on pull requests, so PRs with issues will be automatically detected during review process.

Relates to

  • https://github.com/stanfordnlp/dspy/issues/7823

ulgens avatar Feb 20 '25 13:02 ulgens

I updated the detail but I'm not allowed to rerun the pipeline. Even though that step succeeds, I expect another failure from the actual pre-commit step.

ulgens avatar Feb 20 '25 13:02 ulgens

Thanks so much @ulgens ! Should I merge this now? Or do you want to follow up with a different PR first?

okhat avatar Feb 20 '25 14:02 okhat

@okhat I'd like to apply fixes with several different PRs if that's okay. I don't really want to push a PR with 338 changed files.

ulgens avatar Feb 20 '25 14:02 ulgens

Yes that sounds good to me. But what's your plan? Should we merge this now or wait for other followups?

okhat avatar Feb 20 '25 14:02 okhat

Let's merge this one.

ulgens avatar Feb 20 '25 14:02 ulgens

And then?

okhat avatar Feb 20 '25 14:02 okhat

Then, I'm planning to create PRs like these

  • https://github.com/stanfordnlp/dspy/pull/7827
  • https://github.com/stanfordnlp/dspy/pull/7828

for each hook repos under pre-commit, and finally enable everything, optimize the pre-commit workflow and make it faster.

ulgens avatar Feb 20 '25 19:02 ulgens

@okhat @chenmoneygithub Any luck on revisiting this PR? I saw that some CI work is in progress, this one could be helpful.

ulgens avatar May 03 '25 07:05 ulgens