dspy icon indicating copy to clipboard operation
dspy copied to clipboard

style(dspy): Add type checking and clearer types to BaseSentenceVectorizer

Open harrysalmon opened this issue 10 months ago • 2 comments

There's likely a clearer refactor of this, but as a starter for 10.

It avoids python treating strings as itterables of characters and clarifies the possible input types of some of the child classes. The comments are probably over the top.

harrysalmon avatar Mar 28 '24 19:03 harrysalmon

@harrysalmon happy to merge this PR if ready!

arnavsinghvi11 avatar Apr 13 '24 01:04 arnavsinghvi11

Hi @harrysalmon , just following up again if this PR is ready to merge!

arnavsinghvi11 avatar May 06 '24 01:05 arnavsinghvi11