dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Published 20 hours ago • verified publisher icon stanfordnlp

add 'k' as argument to FaissRM.forward()

Open software-artisan opened this issue 11 months ago • 4 comments

add 'k' as argument to FaissRM.forward()

software-artisan avatar Mar 05 '24 12:03 software-artisan

LGTM! tagging @isaacbmiller as it seems like the ruff fix workflow is erroring out. Is this something on the workflow end? or does it need to be handled within the PR?

arnavsinghvi11 avatar Mar 05 '24 17:03 arnavsinghvi11

Looking into this

isaacbmiller avatar Mar 05 '24 20:03 isaacbmiller

If you run ruff check --fix-only, then commit, it will pass CI.

isaacbmiller avatar Mar 05 '24 20:03 isaacbmiller

LGTM after that

isaacbmiller avatar Mar 05 '24 20:03 isaacbmiller

If you run ruff check --fix-only, then commit, it will pass CI.

@software-artisan

arnavsinghvi11 avatar Mar 09 '24 18:03 arnavsinghvi11