dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Published 20 hours ago • verified publisher icon stanfordnlp

Fix return_all_scores in evaluate

Open quajak opened this issue 5 months ago • 4 comments

Addresses https://github.com/stanfordnlp/dspy/issues/477

quajak avatar Mar 05 '24 04:03 quajak

Thanks @quajak !

@isaacbmiller similar tag here as the PR is failing checks

arnavsinghvi11 avatar Mar 05 '24 17:03 arnavsinghvi11

Hi, not sure why the checks are failing with the current error.

quajak avatar Mar 05 '24 19:03 quajak

This is blocked until #565 is merged. I will have time to finish 565 tomorrow/thursday.

This is only not passing because it comes from a fork instead of the main repo. @quajak if you are okay with not being the author/need this asap (I want you to get the contribution!) I can make a branch.

isaacbmiller avatar Mar 05 '24 23:03 isaacbmiller

I see. Thank you for the explanation. The PR is not urgent, so you can wait with merging until #565 is done.

quajak avatar Mar 06 '24 01:03 quajak

The changes seem to have been reverted by https://github.com/stanfordnlp/dspy/pull/565/commits/e659fc2c001dc4461a931f43a7a070bc17157a6a as part of https://github.com/stanfordnlp/dspy/pull/565 . Was this intentional?

quajak avatar Mar 09 '24 16:03 quajak

I merged and reverted to check if CI would pass, but I still wanted you to merge yours after

isaacbmiller avatar Mar 09 '24 16:03 isaacbmiller

I see, should I make a new PR with the changes?

quajak avatar Mar 10 '24 00:03 quajak

Weird. I guess so @quajak. Tag me and I will merge it

isaacbmiller avatar Mar 10 '24 03:03 isaacbmiller