dspy
dspy copied to clipboard
stanfordnlp
Elastic Search retriever module integration
A retriever module for Elastic Search build during the course of NLU - xCSS224U - Spring 2024. It returns top k document passage sorted based on standard elastic search - query and algorithm.
Looks great.
- could you remove commented out code
- it'd be great if you remove the email in the PR to avoid any spamming, appreciate it :)
Modification done
Thank you!
One more, it would be great if you could add the note for the new client in this folder.
- docs/api/retrieval_model_clients
tagging @isaacbmiller on failed tests. similar issues to previous PRs - could be related to #569 ?
@pmenkidoo just following up on this. can you rebase+merge with main and push again? the PR should be good to merge after that!
Will do.
On Sun, Mar 24, 2024, 4:10 PM arnavsinghvi11 @.***> wrote:
@pmenkidoo https://github.com/pmenkidoo just following up on this. can you rebase+merge with main and push again? the PR should be good to merge after that!
— Reply to this email directly, view it on GitHub https://github.com/stanfordnlp/dspy/pull/534#issuecomment-2016929458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKD26MNU73TZFNRAUNBGW3YZ4XLLAVCNFSM6AAAAABEDS2TLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEZDSNBVHA . You are receiving this because you were mentioned.Message ID: @.***>
Hello,
I am not sure what does it mean to Rebase.
On Thu, Mar 28, 2024 at 4:56 PM Pholysa Mantryvong @.***> wrote:
Will do.
On Sun, Mar 24, 2024, 4:10 PM arnavsinghvi11 @.***> wrote:
@pmenkidoo https://github.com/pmenkidoo just following up on this. can you rebase+merge with main and push again? the PR should be good to merge after that!
— Reply to this email directly, view it on GitHub https://github.com/stanfordnlp/dspy/pull/534#issuecomment-2016929458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKD26MNU73TZFNRAUNBGW3YZ4XLLAVCNFSM6AAAAABEDS2TLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEZDSNBVHA . You are receiving this because you were mentioned.Message ID: @.***>
--
Pholysa Mantryvong
ENKIDOO.ai
W: enkidoo.ai
E: @.***
[image: facebook][image: linkedIn] https://www.linkedin.com/company/enkidoo-technologies-inc-/
DISCLAIMER: This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
Hi @pmenkidoo ,
You have to fetch and rebase the latest changes from the main branch and then push this branch with your updated changes.
Feel free to follow these steps