dspy icon indicating copy to clipboard operation
dspy copied to clipboard

feat(retrieve): add support for faiss retriever, update setup.md, docs

Open jagane opened this issue 2 years ago • 3 comments

Please note that this Pull Request is just an update to the top of the tree and was already discussed in PR #423

jagane avatar Feb 23 '24 18:02 jagane

Thank you. You could just merge/rebase the branch from PR #439 instead.

insop avatar Feb 23 '24 20:02 insop

Hello @insop - Ahh, yes. I could've done that. I will do that next time. This time, github encouraged me to discard my changes and pull from master. I did that, then put my changes back in and tested it, so the new PR #440 is a good patch. Go ahead and merge it in, if you don't mind.

Thanks Jagane

On Fri, Feb 23, 2024 at 12:27 PM Insop @.***> wrote:

Thank you. You could just merge/rebase the branch from PR #439 https://github.com/stanfordnlp/dspy/pull/439 instead.

— Reply to this email directly, view it on GitHub https://github.com/stanfordnlp/dspy/pull/440#issuecomment-1961947875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFW62C6ZVF7BPV6FECJS2DYVD3UVAVCNFSM6AAAAABDXFVKPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRHE2DOOBXGU . You are receiving this because you authored the thread.Message ID: @.***>

jagane avatar Feb 23 '24 20:02 jagane

@okhat , PTAL.

insop avatar Feb 24 '24 01:02 insop

Thanks so much! Looks great

okhat avatar Feb 25 '24 23:02 okhat