dspy icon indicating copy to clipboard operation
dspy copied to clipboard

fixes _get_embeddings for ChromaDB

Open lukaskuhn-lku opened this issue 1 year ago • 1 comments

As described in #389 _get_embeddings is throwing an error when called via retriever(query): TypeError: Embeddings.create() got an unexpected keyword argument 'engine'.

This is a result of the unnecessary usage of model_args and api_provider. I removed both and now the function works as expected.

lukaskuhn-lku avatar Feb 15 '24 16:02 lukaskuhn-lku

@lukaskuhn-lku, it seems like https://github.com/stanfordnlp/dspy/pull/400 update has wider scope changes. Maybe this PR might not be necessary if the newer one (400) is reviewed and merged.

insop avatar Feb 16 '24 00:02 insop

Thank you so much @lukaskuhn-lku ! I will merge #400 so I will close this, but I really appreciate your contribution.

okhat avatar Feb 17 '24 04:02 okhat