dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Allow custom text key to WeaviateRM - resolve issue #359

Open CShorten opened this issue 1 year ago • 1 comments

Lets you specify which text key to return from a call to dspy.Retrieve

This does not incur a breaking change thanks to the Optional typing and default argument value.

This will resolve https://github.com/stanfordnlp/dspy/issues/359.

CShorten avatar Feb 09 '24 03:02 CShorten

With a cursory check, it looks great!

Hi @CShorten,

You could take this suggestion to a separate PR. I think it'd be great if you could add WeaviateRM description to this markdown docs/retrieval_models_client.md. This is a PR that adds description for other RM to this document: https://github.com/stanfordnlp/dspy/pull/400.

insop avatar Feb 16 '24 04:02 insop

Thank you @CShorten and @insop ! Merged

okhat avatar Feb 17 '24 05:02 okhat