dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Published 20 hours ago • verified publisher icon stanfordnlp

Allow HFModel to use CPU

Open tisu19021997 opened this issue 1 year ago • 3 comments

Quick fix https://github.com/stanfordnlp/dspy/issues/188

I think this minor fix could be very helpful for Mac beginners as well as CPU beginners who just get started using the library.

tisu19021997 avatar Feb 07 '24 10:02 tisu19021997

The change looks good to me. One thought is that it would been easier for whoever reads the PR if the changes only the fixes instead other changes such as coding style changes.

insop avatar Feb 10 '24 23:02 insop

@insop thanks. I just reverted the coding style changes.

tisu19021997 avatar Feb 13 '24 17:02 tisu19021997

@insop thanks. I just reverted the coding style changes.

Looks great to me! thank you.

insop avatar Feb 16 '24 04:02 insop

@okhat , maybe you could merge if you are okay with the change?

insop avatar Feb 19 '24 00:02 insop

Merging but please prefer ollama over hfmodel when possible

okhat avatar Feb 19 '24 00:02 okhat