dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Fix bugs in pinecone integration, add support for using cohere embed with pinecone and create basic example notebook

Open DanielUH2019 opened this issue 6 months ago • 5 comments

@CShorten , @okhat this should resolve #322. I removed the _init_pinecone function because I believe it shouldn't be the responsibility of the PineconeRM class to create an index. Let me know what you think.

DanielUH2019 avatar Feb 05 '24 09:02 DanielUH2019

Thank you for the detailed descriptions of the issue and the fix. I did a cursory look at it and it looks good to me.

We need to improve this document for other RMs, but if you could add the entry for pinecone, it would be great.

  • docs/retrieval_models_client.md

insop avatar Feb 18 '24 22:02 insop

Hey @insop , I added an entry for pinecone in the docs

DanielUH2019 avatar Feb 20 '24 03:02 DanielUH2019

Hey @insop , I added an entry for pinecone in the docs

Thank you so much, looks good to me.

insop avatar Feb 20 '24 03:02 insop

Hi @DanielUH2019 , could you merge conflicts locally and commit again? seems like I'm unable to do it within the local command line here but the changes are good to merge!

arnavsinghvi11 avatar Mar 24 '24 20:03 arnavsinghvi11

@DanielUH2019 any updates on addressing the conflicts? facing the same issue with Pinecone AttributeError: init is no longer a top-level attribute of the pinecone package.

csellis avatar May 15 '24 05:05 csellis