dspy icon indicating copy to clipboard operation
dspy copied to clipboard

linter: black & isort for auto-formatting on PRs

Open lawliet19189 opened this issue 1 year ago • 5 comments

lawliet19189 avatar Sep 17 '23 18:09 lawliet19189

What's needed for this to be merged? What are the downsides of merging it? Will it complicate the workflow?

okhat avatar Sep 18 '23 21:09 okhat

I would not split this into separate parts but rather package it all into a dedicated pre-commit + related worflow (which will help much better locally before doing PRs) -> I can set this up.

piotrlaczkowski avatar Jan 18 '24 08:01 piotrlaczkowski

@piotrlaczkowski I invited you to the repo! Please feel free to merge this when you feel it's at a good stage!

okhat avatar Jan 18 '24 15:01 okhat

@okhat I still have 403 upon the push for my new branch, just tested.

piotrlaczkowski avatar Jan 18 '24 16:01 piotrlaczkowski

I think we can close this one (both tools are already present in the pre commit.

piotrlaczkowski avatar Jan 19 '24 18:01 piotrlaczkowski