GloVe icon indicating copy to clipboard operation
GloVe copied to clipboard

About initialize_parameters funtion in glove.c

Open zhezhaoa opened this issue 6 years ago • 0 comments

Thank you for this great implementation. I have a question initialize_parameters funtion in glove.c. Since you have add 1 to the vector_size (vector_size++) , why do you still add 1 on this line? a = posix_memalign((void **)&W, 128, 2 * vocab_size * (vector_size + 1) * sizeof(real)); I think 1 should be removed like this a = posix_memalign((void **)&W, 128, 2 * vocab_size * vector_size * sizeof(real)); I have tested and find that the program runs correctly when 1 is removed

zhezhaoa avatar Aug 27 '17 09:08 zhezhaoa