GloVe icon indicating copy to clipboard operation
GloVe copied to clipboard

GloVe running command 'make' is error

Open Vamco2022 opened this issue 1 year ago • 4 comments

I use the 'make' to build the GloVe, but It's error.

src/glove.c: In function 'initialize_parameters': src/glove.c:103:9: warning: implicit declaration of function 'posix_memalign' [-Wimplicit-function-declaration] 103 | a = posix_memalign((void **)&W, 128, W_size * sizeof(real)); // Might perform better than malloc | ^~~~~~~~~~~~~~ src/glove.c:103:37: warning: 'posix_memalign' argument 2 type is 'int' where 'long long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch] 103 | a = posix_memalign((void **)&W, 128, W_size * sizeof(real)); // Might perform better than malloc | ^~~ : note: built-in 'posix_memalign' declared here src/glove.c:108:42: warning: 'posix_memalign' argument 2 type is 'int' where 'long long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch] 108 | a = posix_memalign((void **)&gradsq, 128, W_size * sizeof(real)); // Might perform better than malloc | ^~~ : note: built-in 'posix_memalign' declared here src/glove.c: In function 'glove_thread': src/glove.c:239:1: warning: control reaches end of non-void function [-Wreturn-type] 239 | } | ^ gcc -c src/common.c -o build/common.o -lm -pthread -O3 -march=native -funroll-loops -Wall -Wextra -Wpedantic src/common.c: In function 'log_file_loading_error': src/common.c:36:39: warning: implicit declaration of function 'strerror_r'; did you mean 'strerror_s'? [-Wimplicit-function-declaration] 36 | #define STRERROR(ERRNO, BUF, BUFSIZE) strerror_r((ERRNO), (BUF), (BUFSIZE)) | ^~~~~~~~~~ src/common.c:151:5: note: in expansion of macro 'STRERROR' 151 | STRERROR(errno, error, MAX_STRING_LENGTH); |

Vamco2022 avatar Jul 05 '24 02:07 Vamco2022

Is this on Windows or something? It builds cleanly for me even with -Wall set on centos stream, probably on other linux builds as well.

AngledLuffa avatar Jul 08 '24 02:07 AngledLuffa

I run it on my Windows, I think the error maybe is produce by the wrong version of gcc. I try to change its version, but always error and stop.

Vamco2022 avatar Jul 08 '24 03:07 Vamco2022

Going forward, please be in the habit of specifying your system and build environment to make it easier to respond...

However, I have to say that there hasn't been much effort put into making GloVe compatible with Windows. I know that you'll need something that includes and links posix. If you find such a thing, and you're able to make a PR that lets it build on both Linux and Windows, we would be more than happy to accept such as PR.

AngledLuffa avatar Jul 08 '24 03:07 AngledLuffa

Since me no able to make the PR file, So I try to build a virtual system on my windows, And now not finish. Thanks your advice.

Vamco2022 avatar Jul 09 '24 11:07 Vamco2022

I am having the same problem on windows 11, any fixed?

vaibhav-OP avatar Jul 20 '25 14:07 vaibhav-OP

I am having the same problem on windows 11, any fixed?

After I found this problem, I didn't get any solution. But I try to run it on my Linux system(ubuntu), It was successed. I think the reason is due the GCC core in Windows and Linux are different. If you want to run it. I recommand you create a virtual machine on your pc and try to run it inside again.

Vamco2022 avatar Aug 10 '25 12:08 Vamco2022

ah makes sense, i will try it thanks a lot .

vaibhav-OP avatar Aug 10 '25 14:08 vaibhav-OP