CoreNLP icon indicating copy to clipboard operation
CoreNLP copied to clipboard

Update to Jollyday 0.5.x and Java 8 java.time instead of JodaTime

Open kno10 opened this issue 9 years ago • 4 comments

Since Java 8 has a time API comparable to JodaTime, projects such as jollyday are switching to this newer API, and so should CoreNLP.

These APIs are quite similar, but the transition is not a simple search and replace.

See e.g. this post for how classes align:

http://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html

kno10 avatar Mar 07 '17 16:03 kno10

In principle, yes, this would be great to do, and we do hope to do it sometime. However, the student who implemented SUTime has graduated, and this isn't currently a critical thing for us to fix, and so it could easily be that 2 years later it still won't have happened.... So, if anyone else were willing to take this on, we'd be much obliged. 🙏

manning avatar Mar 23 '17 04:03 manning

@manning I would like to contribute if I may.

svendiedrichsen avatar Mar 27 '18 22:03 svendiedrichsen

@manning I have updated to Jollyday 0.5.5 and extracted several sub-classes from the SUTime code monster. I think this is in the best interest of code maintainability. I'm now trying to replace Joda with Java8 time. May take some time though.

svendiedrichsen avatar Apr 02 '18 16:04 svendiedrichsen

Just wondering, any progress since then on the Joda->Java8 project? As Erich knows, I'm looking to clear out some old changelists & issues

AngledLuffa avatar Nov 30 '19 05:11 AngledLuffa