CoreNLP icon indicating copy to clipboard operation
CoreNLP copied to clipboard

enable keeping matched expressions.

Open jrsperry opened this issue 2 years ago • 3 comments

All edits are part of the public domain.

This provides more flexibility to the CoreMapExpressionExtractor and the matches returned. I have a use case where I want to see all the available matches, and the name of the rule as specified in the language.

I personally am not using the CompositeRule in my work, but I applied similar updates to the CompositeRule.

jrsperry avatar Oct 10 '22 19:10 jrsperry

In general I don't see any reason not to merge this, but just to confirm, the default settings means it won't change behavior for any existing tokensregex?

AngledLuffa avatar Oct 10 '22 20:10 AngledLuffa

Ping?

AngledLuffa avatar Nov 04 '22 06:11 AngledLuffa

Sorry I don't use Github enough, and as a result this went very stale. Yes the intent was to not change default behavior, rather just add some functionality to the match expression. My use was such that I wanted to use the match expressions more on their own, so I wanted to keep overlapping expressions. This next week I can look at this again and see what additional changes may be needed or reviewed.

jrsperry avatar Oct 17 '23 05:10 jrsperry