spatial-lang icon indicating copy to clipboard operation
spatial-lang copied to clipboard

Warn or Error if Trying to Read to ArgOut in Accel

Open mattfel1 opened this issue 7 years ago • 3 comments

Physically, we can do this. But shouldn't we throw an error since you should be using a HostIO and not an ArgOut? Currently it won't crash anywhere until chisel compilation

mattfel1 avatar Jan 17 '18 03:01 mattfel1

I agree its a bit weird, but by convention so far, ArgOut is just a register that the host can access after Accel executes. HostIO is one that it can access during Accel execution. Effectively that means Accel can do whatever it wants for both ArgOut and HostIO, only the host is limited.

dkoeplin avatar Jan 17 '18 04:01 dkoeplin

Ok I'll correct the codegen and check it inside one of the other unit tests

mattfel1 avatar Jan 17 '18 04:01 mattfel1

There may be an issue when you have a read and write to an argout that is unrolled into multiple parallel accesses. Look into this

mattfel1 avatar Feb 07 '18 01:02 mattfel1