genie-toolkit icon indicating copy to clipboard operation
genie-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon stanford-oval

Wip/translation api

Open Mehrad0711 opened this issue 2 years ago • 3 comments

Mehrad0711 avatar Oct 05 '21 21:10 Mehrad0711

@gcampax Also is there anything else here ? Can we merge it?

Mehrad0711 avatar Oct 15 '21 06:10 Mehrad0711

Do we even need this PR, given we're not doing translation at test time?

I think having a translation endpoint wouldn't hurt even if we don't use it immediately. For po translations, I'm planning to move the genienlp calls from makefile to JS code for which the translateUtterance method is useful.
Also we spent so much time on it, we might as well merge it 🤣

Mehrad0711 avatar Oct 15 '21 22:10 Mehrad0711

The problem is that once you merge an API, you have to support it forever (until the next major API break). You have to compare the small amount of work you did so far, with the future amount of work.

gcampax avatar Oct 15 '21 23:10 gcampax