genie-toolkit icon indicating copy to clipboard operation
genie-toolkit copied to clipboard

Does not compile with npm 7

Open gcampax opened this issue 3 years ago • 2 comments

For some unscrutable reason, npm 7 changed how git deps are prepared, and now repos that use genie-toolkit (like almond-server or thingpedia-common-devices) no longer build genie-toolkit correctly: the templates fail to build because they fail to locate the genie-toolkit.d.ts file

I think the solution here will be to remove entirely the ability to specify templates outside of Genie. Templates will be shipped with Genie and there will only ever be one template pack (+ flags). Programmability of dialogues will come in a different way, by configuring the transaction/slot filling templates with custom ThingTalk logic (see https://wiki.almond.stanford.edu/en/genie/design-notes/unified-control-language for a summary of current designs). @rayslxu opinions? We'll drop sempre templates when we do that.

(originally reported independently by @aydanpirani and @james-zhuang)

gcampax avatar Apr 28 '21 23:04 gcampax

Agree with shipping pre-compiled templates.

sileix avatar Nov 29 '21 19:11 sileix

FWIW that issue should be long solved, but we have other issues with node 16 and npm 7.

gcampax avatar Nov 29 '21 20:11 gcampax