syncing-server icon indicating copy to clipboard operation
syncing-server copied to clipboard

JSON gem deprecation warnings

Open karolsojko opened this issue 4 years ago • 3 comments

We should get rid of those warnings:

/usr/local/bundle/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated,
/usr/local/bundle/gems/activesupport-5.1.7/lib/active_support/notifications/fanout.rb:19: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead,
/usr/local/bundle/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:35: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call,
/usr/local/bundle/gems/actionpack-5.1.7/lib/action_dispatch/middleware/static.rb:109: warning: The called method `initialize' is defined here

karolsojko avatar Aug 04 '20 05:08 karolsojko

Seems like a potential fix: https://piechowski.io/post/last-arg-keyword-deprecated-ruby-2-7/

karolsojko avatar Aug 04 '20 12:08 karolsojko

Mmm... I can't reproduce this.

https://piechowski.io/post/last-arg-keyword-deprecated-ruby-2-7/

This seems to apply for ruby 2.7 but I though we were still on ruby 2.6.5

johnny243 avatar Aug 05 '20 05:08 johnny243

@johnny243 I think it's in the version we use as well - still plenty of those visible on production. Did you try running the Docker image?

karolsojko avatar Aug 05 '20 06:08 karolsojko