desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Add native Wayland support such that it doesn't need to be blurry on HiDPI devices

Open proletarius101 opened this issue 4 years ago • 15 comments

Add native Wayland support such that it doesn't need to be blurry on HiDPI devices

  • [x] Update Node to the latest LTS (14.17.0 LTS)
  • [x] Update Electron to the latest stable (12.0.6)

proletarius101 avatar May 12 '21 11:05 proletarius101

Thanks for the suggestions @proletarius101; I'll forward this over to our desktop and web app dev for review. 🙂

JaspalSuri avatar May 13 '21 02:05 JaspalSuri

Some info about the current situation:

The described blur only occurs when running with GNOME fractional scaling (e.g. 125% scaling not 200%) in Wayland, which is a somewhat experimental feature. Indeed native Wayland support solves that problem though. I see that linked thread is about wlroots, so maybe xwayland apps in HiDPI are always blurry there (so this fix is even more important there).

You will notice on native Wayland in GNOME (Ubuntu, Fedora, Debian) there will be no window decorations due to a lack of CSD (client side decorations) support in Electron. This is being worked on upstream. KDE Wayland and wlroots should not have that issue as they have SSD (server side decorations) support.

Currently native Wayland support is not enabled by default in Electron 12, you'd have to pass --enable-features=UseOzonePlatform --ozone-platform=wayland at runtime.

vchernin avatar Jun 19 '21 07:06 vchernin

Hi @vchernin, thank you for all of those details! I'll be sure to pass this along to the dev team.

JaspalSuri avatar Jun 23 '21 08:06 JaspalSuri

Adding that this is soon / now affecting larger numbers of users, now that Ubuntu 21.10 (releases Oct) and Debian 11 (released) and their derivatives are Wayland by default.

travislankow avatar Sep 15 '21 01:09 travislankow

Thanks for the reminder! I'll bring this up with the team again.

JaspalSuri avatar Sep 16 '21 07:09 JaspalSuri

What version of Electron is SN built on?

--enable-features=UseOzonePlatform --ozone-platform=wayland does not work with the Flatpak. I would suggest upgrading to Electron 14 or 15.

jacob-emery avatar Oct 01 '21 00:10 jacob-emery

I'll get in touch with the dev team and let you know!

JaspalSuri avatar Oct 04 '21 06:10 JaspalSuri

Hello again @jacob-emery, sorry for the delayed response. The desktop app is built with version 9.4 of Electron. We plan to upgrade it to a newer version, though.

JaspalSuri avatar Oct 07 '21 07:10 JaspalSuri

@JaspalSuri thank you for the answer! Yeah, that is great news for us Linux enthusiasts :)

jacob-emery avatar Oct 09 '21 23:10 jacob-emery

You're very welcome! Hopefully we'll be able to use more recent versions without it breaking too many things.

JaspalSuri avatar Oct 11 '21 06:10 JaspalSuri

Another upstream bug to be fixed: https://github.com/electron/electron/pull/33355

proletarius101 avatar Mar 29 '22 13:03 proletarius101

Upstream fix released. @JaspalSuri can you help with updating electron to 17.3.1 (similar to https://github.com/signalapp/Signal-Desktop/pull/5847)?

proletarius101 avatar Apr 03 '22 21:04 proletarius101

Hi @proletarius101, I’m currently not part of the SN team. CC @moughxyz

Thanks for the notification!

JaspalSuri avatar Apr 03 '22 21:04 JaspalSuri

Wayland support added in the Flatpak version: https://github.com/flathub/org.standardnotes.standardnotes/pull/89

proletarius101 avatar May 29 '22 11:05 proletarius101

@proletarius101 You should be aware that CJK folks still have an upstream blocking bug. They cannot enter their language in Wayland Electron apps and there is probably no known workaround at this time. (https://github.com/electron/electron/issues/33662)

ghost avatar Jun 05 '22 02:06 ghost