T-041

Open vr8hub opened this issue 2 years ago • 2 comments

Is there a reason that periods are not included in the t-041 test? I just found one in a review and was surprised lint didn't flag it.

Dec 09 '23 23:12 vr8hub

I don't remember, does adding it and running across the corpus create a lot of false positives?

Dec 09 '23 23:12 acabal

I'll try it and see, I just wanted to make sure there wasn't a known reason first.

Dec 10 '23 00:12 vr8hub

Finally got around to this. I did a grep on [^…]\s[!?;:,.].{0,10} (added period to the second character class) across the entire corpus, no hits. I'll submit a PR to add it.

Mar 21 '24 17:03 vr8hub

And … reverted; I had a stupid typo in my test. It does catch a few things, but there are far more false positives.

Mar 21 '24 20:03 vr8hub