vscode-standard icon indicating copy to clipboard operation
vscode-standard copied to clipboard

Bind to "format document" key binding

Open penrillian-chrisa opened this issue 8 years ago • 6 comments

Should this plugin automatically bind to the default "format document" key binding?

(It works just fine in chenxsan.vscode-standard-format)

penrillian-chrisa avatar Jan 12 '17 09:01 penrillian-chrisa

No, I think it would be confusing when all those plugins automatically bind to the default format document key binding. So it won't be supported unless necessary.

chenxsan avatar Feb 15 '17 13:02 chenxsan

Would you please consider making this configurable?

brucx avatar Feb 02 '18 05:02 brucx

@brucx haha, I don't find any free time to implement this. You can submit a pull request if you like, I'm willing to merge it.

chenxsan avatar Feb 02 '18 12:02 chenxsan

Would you please consider making this configurable?

How would that be different from now? The user can just bind the Formatting Hotkey to JS Fix Problems and has the same effect !?

falco467 avatar Jun 21 '19 13:06 falco467

https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

The problem with creating a user shortcut is that is not easily shared between platforms (see Settings Sync) and other developers (shared projects). It would be much nicer to have a proper formatter.

mcdado avatar Sep 13 '21 16:09 mcdado

No, I think it would be confusing when all those plugins automatically bind to the default format document key binding. So it won't be supported unless necessary.

I do not understand. All the extensions I have used (Rust, C++, Java, Python) just plug in into the API – why should this extension be different? VSCode already provides settings to configure formatters per language.

jurf avatar Nov 27 '21 17:11 jurf