standard-engine icon indicating copy to clipboard operation
standard-engine copied to clipboard

Include snazzy in package

Open zaynv opened this issue 7 years ago • 5 comments

hi there, I saw the great talk by feross on using standard-engine to wrap our eslint configs. i see that snazzy is a separate tool used to make the output look nice. Is there a way to include the snazzy output with our custom CLI created from standard-engine, or would it be necessary to make some code changes? it would be nice to not have to install two packages everytime you want to lint.

And thanks for this cool package

zaynv avatar Feb 17 '18 02:02 zaynv

Would love to be able to do this as well. I don't see an obvious way to do it as the current standardEngine.cli(...) returns undefined. If someone points me in the right direction, I'd be happy to poke a bit more.

rjhilgefort avatar Jun 22 '18 16:06 rjhilgefort

Indeed, it would be a cool feature to have! As discussed in : https://github.com/standard/ts-standard/issues/102, https://github.com/standard/standard/issues/1356

I would love to open a PR to implement that, but I have no idea what to do in the code. Could we have more insight of what's going on when we do standard | snazzy for example ? Maybe @feross could help us to implement that. We could have a new cli option : --report=pretty.

theoludwig avatar Dec 09 '20 18:12 theoludwig

I will consider this for the next major version of standard

feross avatar Feb 23 '21 19:02 feross

I think if we were to do this, we'd want to consider exposing the built in --format option in ESLint https://github.com/standard/standard/issues/1286 This name would conflict with the prettier --format option, so we need to think about how to handle that.

feross avatar Feb 23 '21 19:02 feross

Maybe we could do like ts-standard does, indeed exposing the --format eslint option but instead the option would be --report still in standard-engine.

theoludwig avatar Mar 16 '21 06:03 theoludwig