eslint-config-standard-react
eslint-config-standard-react copied to clipboard
Eslint plugin react hooks
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [ ] Bug fix [x ] New feature [ ] Other, please explain:
What changes did you make? (Give an overview)
- Updated base config to use
eslint-plugin-react-hooks
. - Updated test
I saw the other PR was quite a mess for such small changes so I created a new one.
Which issue (if any) does this pull request address?
#57
Is there anything you'd like reviewers to focus on?
🙌 Thanks for opening this pull request! You're awesome.
is it expected to see this PR merged any time soon?
What's preventing this PR from being merged ?
What's preventing this PR from being merged ?
![Screenshot 2022-12-01 at 12 22 12](https://user-images.githubusercontent.com/189580/205028195-fc7bf549-642e-4cca-a0f1-502aa7aae74e.png)
So I guess I should start a new PR, based on these changes and your remarks, but without the conflicts ;-) I'll get on it, it's high time standard-react uses these rules ! PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot
PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot
Did not know that, thanks for telling me!
If you're creating a new PR, I have added the .gitignore
changes in #74, so no need to add that 👍
Here is the new PR to solve this issue, but without the conflicts ;-) https://github.com/standard/eslint-config-standard-react/pull/75
added in #75