eslint-config-standard-react icon indicating copy to clipboard operation
eslint-config-standard-react copied to clipboard

Eslint plugin react hooks

Open vndre opened this issue 3 years ago • 2 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [x ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

  1. Updated base config to use eslint-plugin-react-hooks.
  2. Updated test

I saw the other PR was quite a mess for such small changes so I created a new one.

Which issue (if any) does this pull request address?

#57

Is there anything you'd like reviewers to focus on?

vndre avatar Feb 11 '21 18:02 vndre

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] avatar Feb 11 '21 18:02 welcome[bot]

is it expected to see this PR merged any time soon?

ivanbanov avatar Oct 27 '21 16:10 ivanbanov

What's preventing this PR from being merged ?

barroudjo avatar Nov 15 '22 16:11 barroudjo

What's preventing this PR from being merged ?

Screenshot 2022-12-01 at 12 22 12

LinusU avatar Dec 01 '22 10:12 LinusU

So I guess I should start a new PR, based on these changes and your remarks, but without the conflicts ;-) I'll get on it, it's high time standard-react uses these rules ! PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot

barroudjo avatar Dec 01 '22 10:12 barroudjo

PS: non maintainers / author of the PR can't see what the conflicts are, so it's good you joined that screenshot

Did not know that, thanks for telling me!

If you're creating a new PR, I have added the .gitignore changes in #74, so no need to add that 👍

LinusU avatar Dec 01 '22 11:12 LinusU

Here is the new PR to solve this issue, but without the conflicts ;-) https://github.com/standard/eslint-config-standard-react/pull/75

barroudjo avatar Dec 06 '22 14:12 barroudjo

added in #75

LinusU avatar Dec 15 '22 11:12 LinusU