Adrian Stanciu

Results 25 comments of Adrian Stanciu

> Is there an ETA on when this will go back out of draft form? I cant imagine anyone else reviewing this PR until that point. I have finished reviewing...

> might be helpful for someone trying to understand the decryption code Added ASCII diagrams for encryption and decryption and more comments. Please let me know if they're detailed enough.

> Is this still a draft? Everything is in place and ready to go forward.

> Can you please squash the commits into one or two commits? I think the initial refactoring could be kept as separate commit but please squash the rest. Yes, it's...

`ossl_aes_cfb128_vaes_eligible` was also called for AES-CFB1 and AES-CFB8: ```c // gcc -E providers/implementations/ciphers/cipher_aes_cfb_hw.c -Iinclude -Iproviders/implementations/include static const PROV_CIPHER_HW aes_cfb128 = {cipher_hw_aes_initkey, ossl_cipher_hw_generic_cfb128, cipher_hw_aes_copyctx}; static const PROV_CIPHER_HW aesni_cfb128 = {cipher_hw_aesni_initkey, ossl_cipher_hw_generic_cfb128,...