stanc3
stanc3 copied to clipboard
Mark binomial logit and glm as opencl-supported
Submission Checklist
This PR marks the binomial_logit and binomial_logit_glm distributions as OpenCL-supported. The binomial_logit_glm support was only recently added, but the binomial_logit distributions appears to have already had support but just hadn't been enabled.
Let me know if I've missed any tests/checks that also need to be made!
- [x] Run unit tests
- Documentation
- [ ] If a user-facing facing change was made, the documentation PR is here: <LINK>
- [x] OR, no user-facing changes were made
Release notes
Enabled OpenCL support for the binomial_logit and binomial_logit_glm distributions
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.49%. Comparing base (
c5721d7) to head (b4285d0). Report is 3 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1368 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 63 63
Lines 10618 10618
=======================================
Hits 9503 9503
Misses 1115 1115
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/stan_math_backend/Transform_Mir.ml | 95.77% <ø> (ø) |
With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is
With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is
Oh neat, that will be really nice to have
@WardBrian would it be alright for this to go in?