stan-dev
update constraints to have checks for negative or zero sizes
Submission Checklist
- [x] Run unit tests:
./runTests.py src/test/unit - [x] Run cpplint:
make cpplint - [x] Declare copyright holder and open-source license: see below
Summary
Related to #3366 this adds checks to deserializer so that negative numbers or size 0 integers are not accepted by constraints when they would not be valid.
For a few of the constraints we do allow size zero matrices, but were previously not handling them nicely. For instance cholesky_factor_cov requests (N * (N + 1)) / 2 + (M - N) * N doubles from the deserializers vector. If M=0 we could end up requesting negative amounts of memory.
Intended Effect
Check valid requests to deserializer early.
How to Verify
Tests were added to the deserializer's test suite and can be run with
python3 ./runTests.py -j8 ./src/test/unit/io/deserializer_test.cpp
Documentation
No new docs
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
| Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
|---|---|---|---|---|
| arma/arma.stan | 0.3 | 0.29 | 1.02 | 1.6% faster |
| low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.99 | -0.79% slower |
| gp_regr/gen_gp_data.stan | 0.03 | 0.02 | 1.03 | 3.3% faster |
| gp_regr/gp_regr.stan | 0.09 | 0.09 | 1.02 | 1.79% faster |
| sir/sir.stan | 72.83 | 71.45 | 1.02 | 1.9% faster |
| irt_2pl/irt_2pl.stan | 4.36 | 4.19 | 1.04 | 3.91% faster |
| eight_schools/eight_schools.stan | 0.06 | 0.06 | 1.0 | 0.32% faster |
| pkpd/sim_one_comp_mm_elim_abs.stan | 0.26 | 0.25 | 1.03 | 2.7% faster |
| pkpd/one_comp_mm_elim_abs.stan | 20.54 | 19.93 | 1.03 | 2.93% faster |
| garch/garch.stan | 0.45 | 0.42 | 1.08 | 7.47% faster |
| low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.88 | 2.75 | 1.04 | 4.28% faster |
| arK/arK.stan | 1.89 | 1.82 | 1.04 | 3.93% faster |
| gp_pois_regr/gp_pois_regr.stan | 3.03 | 2.9 | 1.04 | 4.25% faster |
| low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.17 | 8.85 | 1.04 | 3.46% faster |
| performance.compilation | 184.03 | 184.46 | 1.0 | -0.23% slower |
| Mean result: 1.0284197958398023 |
Jenkins Console Log Blue Ocean Commit hash: ffac0da73b69979c07241aca2aae80ed0a782634
Machine information
No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 46 bits physical, 48 bits virtual CPU(s): 80 On-line CPU(s) list: 0-79 Thread(s) per core: 2 Core(s) per socket: 20 Socket(s): 2 NUMA node(s): 2 Vendor ID: GenuineIntel CPU family: 6 Model: 85 Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz Stepping: 4 CPU MHz: 2400.000 CPU max MHz: 3700.0000 CPU min MHz: 1000.0000 BogoMIPS: 4800.00 Virtualization: VT-x L1d cache: 1.3 MiB L1i cache: 1.3 MiB L2 cache: 40 MiB L3 cache: 55 MiB NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78 NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79 Vulnerability Gather data sampling: Mitigation; Microcode Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Mitigation; IBRS Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities
G++: g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Clang: clang version 10.0.0-4ubuntu1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin
| Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
|---|---|---|---|---|
| arma/arma.stan | 0.3 | 0.3 | 1.01 | 0.69% faster |
| low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.97 | -3.18% slower |
| gp_regr/gen_gp_data.stan | 0.03 | 0.03 | 1.0 | 0.42% faster |
| gp_regr/gp_regr.stan | 0.09 | 0.1 | 0.93 | -7.63% slower |
| sir/sir.stan | 72.11 | 71.76 | 1.0 | 0.49% faster |
| irt_2pl/irt_2pl.stan | 4.41 | 4.14 | 1.07 | 6.26% faster |
| eight_schools/eight_schools.stan | 0.06 | 0.06 | 1.02 | 2.26% faster |
| pkpd/sim_one_comp_mm_elim_abs.stan | 0.26 | 0.25 | 1.03 | 3.04% faster |
| pkpd/one_comp_mm_elim_abs.stan | 20.66 | 19.9 | 1.04 | 3.71% faster |
| garch/garch.stan | 0.52 | 0.42 | 1.23 | 18.94% faster |
| low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.93 | 2.75 | 1.06 | 6.1% faster |
| arK/arK.stan | 1.9 | 1.81 | 1.05 | 4.55% faster |
| gp_pois_regr/gp_pois_regr.stan | 3.14 | 2.94 | 1.07 | 6.34% faster |
| low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.31 | 8.87 | 1.05 | 4.66% faster |
| performance.compilation | 185.62 | 184.14 | 1.01 | 0.8% faster |
| Mean result: 1.0363183607927706 |
Jenkins Console Log Blue Ocean Commit hash: ffac0da73b69979c07241aca2aae80ed0a782634
Machine information
No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 46 bits physical, 48 bits virtual CPU(s): 80 On-line CPU(s) list: 0-79 Thread(s) per core: 2 Core(s) per socket: 20 Socket(s): 2 NUMA node(s): 2 Vendor ID: GenuineIntel CPU family: 6 Model: 85 Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz Stepping: 4 CPU MHz: 2936.917 CPU max MHz: 3700.0000 CPU min MHz: 1000.0000 BogoMIPS: 4800.00 Virtualization: VT-x L1d cache: 1.3 MiB L1i cache: 1.3 MiB L2 cache: 40 MiB L3 cache: 55 MiB NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78 NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79 Vulnerability Gather data sampling: Mitigation; Microcode Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Mitigation; IBRS Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities
G++: g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Clang: clang version 10.0.0-4ubuntu1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin
@WardBrian now that we found the fix in stanc3, do you think this is necessary? This will only ever be used by the code generator, so unless the code generator has a bug in it then we should not need these.
I don’t think they are strictly necessary, but it’s a bit odd that before this PR some of them have checks and some of them don’t
