stan icon indicating copy to clipboard operation
stan copied to clipboard

FR: `model_base` methods - use `Eigen::Ref<Eigen::VectorXd>`

Open andrjohns opened this issue 1 year ago • 0 comments
trafficstars

Summary:

The Eigen overloads for model base methods like log_prob and unconstrain_array only accept Eigen::VectorXd inputs, which can require some data-reshaping/copying for downstream interfaces.

If these could be changed to Eigen::Ref<Eigen::VectorXd> (or overloads for these added), then the current Stan behaviour would be unchanged but interfaces could then pass Eigen::Map<Eigen::VectorXd> types and avoid extra copies

Current Version:

v2.35.0

andrjohns avatar May 23 '24 21:05 andrjohns