stan icon indicating copy to clipboard operation
stan copied to clipboard

relax requirement on final / in include paths

Open bob-carpenter opened this issue 7 years ago • 3 comments

Summary:

The include path mechanism currently appends the file name to the path, which requires the path to end in /. Instead, check if the path ends in a separator, and if not, add one.

@ahartikainen originally brought this up in: https://github.com/stan-dev/pystan/pull/438#issuecomment-367004027

Current Version:

v2.17.1

bob-carpenter avatar Feb 20 '18 18:02 bob-carpenter

Also, if it cannot find the #included file, the error message should reference the file name that it did not find.

bgoodri avatar Feb 21 '18 02:02 bgoodri

Should the milestone for this be bumped? This would be great to get in.

ariddell avatar Mar 31 '18 16:03 ariddell

Hi,

could the code also ignore whitespace before and after the statement?

E.g. https://stackoverflow.com/a/216883

ahartikainen avatar Apr 28 '18 08:04 ahartikainen

Issue no longer exists in stanc3

WardBrian avatar Mar 20 '23 18:03 WardBrian