rstantools icon indicating copy to clipboard operation
rstantools copied to clipboard

reloo generic

Open jgabry opened this issue 5 years ago • 3 comments

@paul-buerkner I'd like to add a generic for reloo so we can have reloo.stanreg and reloo.brmsfit methods. But I see that currently brms takes the first argument of reloo to be the loo object. So it can't change to a brmsfit method without breaking backwards compatibility, right? If that's the case then maybe we should use a different name than reloo for the generic and new methods and you can deprecate reloo it in brms. What do you think? Definitely open to other ideas.

jgabry avatar Apr 17 '19 01:04 jgabry

I could just add a reloo.loo method to brms or we can even add it to loo and then internally do the dispatch based on the second, model object argument. This way, we won't break backwards compatibility but still get the generic going I think.

paul-buerkner avatar Apr 17 '19 06:04 paul-buerkner

Was there resolution for this?

avehtari avatar Jan 15 '24 12:01 avehtari

Bumping this reloo question up again

avehtari avatar Apr 12 '24 07:04 avehtari