rstanarm icon indicating copy to clipboard operation
rstanarm copied to clipboard

Reminder to fix version numbers in Makevars files

Open jgabry opened this issue 2 years ago • 2 comments

CRAN is adding a warning if package version numbers are not strings (e.g. 2.26 vs '2.26'). This needs to be fixed in rstanarm's Makevars files.

jgabry avatar Jul 24 '23 23:07 jgabry

@bgoodri I assume you got the email, but CRAN asked for this to be resolved by 2023-09-13, so about 2 weeks. We could just manually edit the Makevars files, but do you want to have rstantools just generate them instead?

RStan is more urgent so no worries about this in the next few days I guess, just wanted to put an update here.

jgabry avatar Aug 31 '23 18:08 jgabry

We're close enough on rstan that I believe we will have time to convert rstanarm to the new rstantools and array syntax by the 13th.

On Thu, Aug 31, 2023 at 2:54 PM Jonah Gabry @.***> wrote:

@bgoodri https://github.com/bgoodri I assume you got the email, but CRAN asked for this to be resolved by 2023-09-13, so about 2 weeks. We could just manually edit the Makevars files, but do you want to have rstantools just generate them instead?

RStan is more urgent so no worries about this in the next few days I guess, just wanted to put an update here.

— Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstanarm/issues/595#issuecomment-1701591053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ2XKVP4XQEWDISAKU7TRDXYDMWPANCNFSM6AAAAAA2WIEIFY . You are receiving this because you were mentioned.Message ID: @.***>

bgoodri avatar Sep 07 '23 02:09 bgoodri