rstanarm icon indicating copy to clipboard operation
rstanarm copied to clipboard

Fix compilation under rstan 2.26

Open andrjohns opened this issue 4 years ago • 3 comments

This PR adds Makevars flags needed to build rstanarm against the new 2.26 version of rstan

andrjohns avatar Apr 24 '21 08:04 andrjohns

Thanks @andrjohns! Will this now only work with 2.26 or will it still also work fine with older versions?

jgabry avatar May 07 '21 23:05 jgabry

Looks like I missed a comment from @hsbadr on this! This flag should only be defined if the associated rstan version is >= 2.26. (that comment here). So this flag should be conditionally included using if (utils::packageVersion("rstan") >= 2.26). I'll have a look into fixing this up

andrjohns avatar May 08 '21 01:05 andrjohns

Ok great thanks!

jgabry avatar May 08 '21 04:05 jgabry

Superseded by #574

andrjohns avatar Sep 14 '22 10:09 andrjohns