rstanarm icon indicating copy to clipboard operation
rstanarm copied to clipboard

build process and directory structure won't match rstantools 2.0.0

Open jgabry opened this issue 6 years ago • 5 comments

Whenever we release rstantools 2.0.0 is released (https://github.com/stan-dev/rstantools/pull/44) build process and directory structure won't match what we currently have in rstanarm. @bgoodri were you thinking we would change rstanarm to match the new stuff in rstantools before the next rstanarm release? If not then we probably shouldn't have rstantools recommend to developers that they consult the rstanarm source code for examples. I think we may have discussed this but I don't remember what we decided, if anything.

jgabry avatar May 04 '19 17:05 jgabry

We should release both and then shortly thereafter change the structure of rstanarm on GitHub to what rstantools would create for a new package.

On Sat, May 4, 2019 at 1:12 PM Jonah Gabry [email protected] wrote:

Whenever we release rstantools 2.0.0 is released (stan-dev/rstantools#44 https://github.com/stan-dev/rstantools/pull/44) build process and directory structure won't match what we currently have in rstanarm. @bgoodri https://github.com/bgoodri were you thinking we would change rstanarm to match the new stuff in rstantools before the next rstanarm release? If not then we probably shouldn't have rstantools recommend to developers that they consult the rstanarm source code for examples. I think we may have discussed this but I don't remember what we decided, if anything.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstanarm/issues/355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ2XKV3UU4LEIOYA5YOWJDPTW7XJANCNFSM4HKZK5QQ .

bgoodri avatar May 04 '19 17:05 bgoodri

Ok, sounds good to me.

jgabry avatar May 04 '19 17:05 jgabry

Perhaps we should clarify that developers should look at the rstanarm repo on GitHub rather than the .tar.gz file on CRAN, which has a bunch of important stuff omitted due to .Rbuildignore anyway.

On Sat, May 4, 2019 at 1:38 PM Jonah Gabry [email protected] wrote:

Ok, sounds good to me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstanarm/issues/355#issuecomment-489348237, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ2XKSYUBYQXXNARR5JYZTPTXC2LANCNFSM4HKZK5QQ .

bgoodri avatar May 04 '19 17:05 bgoodri

Yeah we should clarify that

jgabry avatar May 05 '19 04:05 jgabry

Commenting here to remind us to do this now that rstanarm was released

jgabry avatar Oct 04 '19 20:10 jgabry