stan-dev
Update plugin libs arg for inline and 4.2 compatibility
@bgoodri or @jgabry, this PR fixes compatibility of rstan 2.21 with R4.2 (using the fix implemented by @hsbadr for 2.26).
This resolves the errors seen in #1007 and this forum post
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
- Code: GPLv3 (http://opensource.org/licenses/GPL-3.0)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
Thanks Andrew! @bgoodri can you take a look and merge if it seems ok? I’m feeling pretty out of it (COVID) so I don’t trust myself to review anything at the moment. Lots of people have been asking about issues with R4.2 though so we should get this in as soon as possible.
On Fri, May 6, 2022 at 10:59 AM Andrew Johnson @.***> wrote:
@bgoodri https://github.com/bgoodri or @jgabry https://github.com/jgabry, this PR fixes compatibility of rstan 2.21 with R4.2 (using the fix implemented by @hsbadr https://github.com/hsbadr for 2.26).
This resolves the errors seen in #1007 https://github.com/stan-dev/rstan/issues/1007 and this forum post https://discourse.mc-stan.org/t/after-trying-to-update-brms-cannot-run-model/20659/9 Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
- Code: GPLv3 (http://opensource.org/licenses/GPL-3.0)
- Documentation: CC-BY 4.0 ( https://creativecommons.org/licenses/by/4.0/)
You can view, comment on, or merge this pull request online at:
https://github.com/stan-dev/rstan/pull/1008 Commit Summary
- 893aa40 https://github.com/stan-dev/rstan/pull/1008/commits/893aa40d1d9fa7c206fb8df58f8bc9d9f54f3098 Update libs arg for inline and 4.2 compatibility
File Changes
(1 file https://github.com/stan-dev/rstan/pull/1008/files)
- M rstan/rstan/R/plugin.R https://github.com/stan-dev/rstan/pull/1008/files#diff-cf22d8a9d8c4b1f76afa5d1853516d2ae2d7cc4e01ac7e190fb845539848fec1 (2)
Patch Links:
- https://github.com/stan-dev/rstan/pull/1008.patch
- https://github.com/stan-dev/rstan/pull/1008.diff
— Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstan/pull/1008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3PQQ7K3JY2FH2CZOPC47DVIUXT3ANCNFSM5VINN2OA . You are receiving this because you were mentioned.Message ID: @.***>
I don't have time at the moment due to final exams going on. I know there was a reason I used LOCAL_LIBS rather than PKG_LIBS on Windows at one point, but I would have to go back and remember what that reason was or if it is still applicable.
On Mon, May 9, 2022 at 12:44 PM Jonah Gabry @.***> wrote:
Thanks Andrew! @bgoodri can you take a look and merge if it seems ok? I’m feeling pretty out of it (COVID) so I don’t trust myself to review anything at the moment. Lots of people have been asking about issues with R4.2 though so we should get this in as soon as possible.
On Fri, May 6, 2022 at 10:59 AM Andrew Johnson @.***> wrote:
@bgoodri https://github.com/bgoodri or @jgabry https://github.com/jgabry, this PR fixes compatibility of rstan 2.21 with R4.2 (using the fix implemented by @hsbadr https://github.com/hsbadr for 2.26).
This resolves the errors seen in #1007 https://github.com/stan-dev/rstan/issues/1007 and this forum post < https://discourse.mc-stan.org/t/after-trying-to-update-brms-cannot-run-model/20659/9
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
- Code: GPLv3 (http://opensource.org/licenses/GPL-3.0)
- Documentation: CC-BY 4.0 ( https://creativecommons.org/licenses/by/4.0/)
You can view, comment on, or merge this pull request online at:
https://github.com/stan-dev/rstan/pull/1008 Commit Summary
- 893aa40 < https://github.com/stan-dev/rstan/pull/1008/commits/893aa40d1d9fa7c206fb8df58f8bc9d9f54f3098
Update libs arg for inline and 4.2 compatibility
File Changes
(1 file https://github.com/stan-dev/rstan/pull/1008/files)
- M rstan/rstan/R/plugin.R < https://github.com/stan-dev/rstan/pull/1008/files#diff-cf22d8a9d8c4b1f76afa5d1853516d2ae2d7cc4e01ac7e190fb845539848fec1
(2)
Patch Links:
- https://github.com/stan-dev/rstan/pull/1008.patch
- https://github.com/stan-dev/rstan/pull/1008.diff
— Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstan/pull/1008, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB3PQQ7K3JY2FH2CZOPC47DVIUXT3ANCNFSM5VINN2OA
. You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstan/pull/1008#issuecomment-1121334391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ2XKUIBOPQJMUP7S7PHSLVJE6FHANCNFSM5VINN2OA . You are receiving this because you were mentioned.Message ID: @.***>
