posterior icon indicating copy to clipboard operation
posterior copied to clipboard

New CRAN release?

Open n-kall opened this issue 1 year ago • 6 comments

There have been several small features included since the last CRAN release, including:

  • thin_draws now does automatic thinning
  • subset_draws has exclude option (currently if a user uses exclude = TRUE with CRAN version, it just ignores it silently, leading to the opposite behaviour as expected)
  • pareto_smooth can be used properly with log weights (in weight_draws, but also the are_log_weights argument)
  • new user facing functions pareto_* diagnostics
  • new extract_variable_array function

Soon there should be larger changes merged (e.g. weighted draws updates, changes to summarise_draws backend to use rvars) which might constitute a larger release. But as the currently merged features are now being used in public case studies (e.g. from @avehtari), perhaps it is a good time to push a point update to CRAN? @paul-buerkner @mjskay

n-kall avatar May 10 '24 07:05 n-kall

+1

I am not teaching this quarter, so I will also start to have time to iterate on the bigger things again too. I like the idea of a small release first.

mjskay avatar May 10 '24 08:05 mjskay

  • It would be nice to include PR #361, if we can agree on the names
  • There are some issues that might be small enough to fix?
    • #365
    • #359
    • #358
    • #355
    • #346
    • #338
    • #322
    • #315
    • #310

EDIT: formatting

avehtari avatar May 10 '24 09:05 avehtari

I don't really have time to work much on posterior at the moment. Any of these issues that @mjskay, @n-kall or you can address?

paul-buerkner avatar May 14 '24 11:05 paul-buerkner

Any of these issues that @mjskay, @n-kall or you can address?

Yes, I should be able to prepare PRs for at least those related to pareto diags. A couple of these issues will need decisions regarding naming e.g. #361, #346, which might need further input from others

n-kall avatar May 14 '24 11:05 n-kall

I can probably take a look at some of the others in about a week and a half (at a conference currently)

mjskay avatar May 14 '24 17:05 mjskay

Thank you both!

paul-buerkner avatar May 14 '24 21:05 paul-buerkner

Several of the bugs @avehtari listed have now been fixed. @mjskay Any thoughts on the others / should they wait until the next CRAN release?

n-kall avatar Jun 26 '24 12:06 n-kall

I unfortunately don't have time to work more on posterior at the moment. But I am happy to do a new CRAN release now. @avehtari what are your thoughts?

paul-buerkner avatar Jun 27 '24 08:06 paul-buerkner

I'd like to include the new Pareto-k-diagnostic vignette https://github.com/stan-dev/posterior/pull/372

avehtari avatar Jun 27 '24 11:06 avehtari

The Pareto vignette has been merged. I also don't have time now to add or fix anything else, so ok with the new CRAN release

avehtari avatar Jun 28 '24 08:06 avehtari

Okay. Will submit it today

paul-buerkner avatar Jun 28 '24 10:06 paul-buerkner

Thanks - sorry I didn’t get to other issues, it’s been a crazy quarter. I’m hoping to swing back around on some of my outstanding issues this summer, including bigger changes like weighted rvars, but those can wait until after this next release.

mjskay avatar Jun 28 '24 15:06 mjskay

I see 1.6.0 now on CRAN, thanks @paul-buerkner ! Also, should the pkgdown website be rebuilt or is it an automatic process?

n-kall avatar Jul 04 '24 05:07 n-kall

I will have to do this. Will do today.

Am Do., 4. Juli 2024 um 07:40 Uhr schrieb Noa Kallioinen < @.***>:

I see 1.6.0 now on CRAN, thanks @paul-buerkner https://github.com/paul-buerkner ! Also, should the pkgdown website be rebuilt or is it an automatic process?

— Reply to this email directly, view it on GitHub https://github.com/stan-dev/posterior/issues/367#issuecomment-2208156533, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCW2ADQJDCKUFVTC7EBPTLZKTN57AVCNFSM6AAAAABHQEQFNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGE2TMNJTGM . You are receiving this because you were mentioned.Message ID: @.***>

paul-buerkner avatar Jul 05 '24 08:07 paul-buerkner