math icon indicating copy to clipboard operation
math copied to clipboard

Keeping `5.0-breaking-changes` up-to-date with `develop`

Open syclik opened this issue 1 year ago • 3 comments

Summary

Updating the 5.0-breaking-changes branch with the latest updates to develop.

syclik avatar Apr 22 '24 13:04 syclik

Should we merge this to the 5.0 branch?

SteveBronder avatar Apr 26 '24 18:04 SteveBronder

Confused with what we are doing on this branch? Should we just be updating the 5.0 breaking changes branch directly?

SteveBronder avatar May 16 '24 16:05 SteveBronder

Sorry about that. I thought the 5.0 branch was protected. If it's not, we should just keep it up to date.

And we can close this PR.

syclik avatar May 17 '24 17:05 syclik

Yes sorry I did that and forgot to say something. I removed the protection because I wanted to update it. I was going to do it this way, but then it involves making the pr originally to the develop branch and then switching to the 5.0 branch which imo is kind of annoying. Since the 5.0 branch runs the tests we can just update it locally, run the tests, and when the tests pass push up the merge

SteveBronder avatar May 17 '24 19:05 SteveBronder

No worries! Makes sense.

syclik avatar May 18 '24 00:05 syclik