updating opencl multi_normal_cholesky_lpdf to match the other implementation

[syclik]

Summary

#3002 missed checking cholesky factor for the opencl version of multi_normal_cholesky_lpdf.

This PR adds in the check_cholesky_factor. This should now pass the CI tests.

Tests

No new tests. There is a current test in develop that fails when running with opencl.

Side Effects

None.

Release notes

Updating opencl multi_cholesky_normal_lpdf implementation to check that the input is a valid cholesky factor.

Checklist

• [x] Copyright holder: Daniel Lee

  The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses: - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause) - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

• [ ] the basic tests are passing

  • unit tests pass (to run, use: ./runTests.py test/unit)
  • header checks pass, (make test-headers)
  • dependencies checks pass, (make test-math-dependencies)
  • docs build, (make doxygen)
  • code passes the built in C++ standards checks (make cpplint)

• [x] the code is written in idiomatic C++ and changes are documented in the doxygen

• [ ] the new changes are tested

[SteveBronder]

I think we need an opencl version of check_cholesky_factor to have parity

[syclik]

Yup! You're absolutely right. I'll get to it soon.

On Tue, Feb 6, 2024 at 11:01 AM Steve Bronder @.***> wrote:

I think we need an opencl version of check_cholesky_factor to have parity

— Reply to this email directly, view it on GitHub https://github.com/stan-dev/math/pull/3021#issuecomment-1930125752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADH6F4I6OEKVHTVGNBIJPTYSJHXFAVCNFSM6AAAAABC3FIIRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGEZDKNZVGI . You are receiving this because you authored the thread.Message ID: @.***>