stan-dev
Remove support for CmdStan pre-2.34 in a future version
Summary:
It would be nice to remove a lot of legacy code in the package which has been made obsolete by recent CmdStan updates. For example, supporting running multiple chains without using the num_chains argument to CmdStan
Current Version:
1.1
I updated my wish in the title to be only supporting 2.34 and newer so we can assume the existence of the save_cmdstan_config (https://github.com/stan-dev/cmdstanpy/issues/714) and save_metric (https://github.com/stan-dev/cmdstanpy/issues/713) arguments
After another year, it would make sense to make this 2.37, which will allow passing comma-separated lists of filenames and make a lot of our logic in runset completely obsolete
Regarding dropping support for older versions: for what it's worth, I would lean towards being a bit more aggressive with only maintaining support for recent versions (or perhaps tying some of cmdstanpy's versioning to cmdstan versioning?) I think it makes sense for a wrapper interface to proceed mostly in step with the tool it's wrapping.
The added degree of freedom of trying to map out the behavior of this code along with how things have changed over the last few years in cmdstan adds a bit of complexity if you don't already have a good handle on it.
From a user perspective; warning a user to install a new version of cmdstan or downgrade cmdstanpy if there a mismatch seems not so bad.
