cmdstan icon indicating copy to clipboard operation
cmdstan copied to clipboard

`stansummary` save to CSV doesn't respect default significant figures

Open mitzimorris opened this issue 3 years ago • 1 comments

Summary:

Utility stansummary use of sig figs combined with scientific notation results in only 2 digit's worth of precision.

Description:

cf: https://github.com/stan-dev/cmdstanpy/issues/550#issuecomment-1081108389

It seems that the CSV output doesn't respect the default sig-figs that the docs cite.

without specifying -s:

name,Mean,MCSE,StdDev,5%,50%,95%,N_Eff,N_Eff/s,R_hat "lp__",-7.29137,0.0194958,0.751762,-8.82028,-6.99659,-6.74977,1486.9,19062.8,0.999907 with -s 2

name,Mean,MCSE,StdDev,5%,50%,95%,N_Eff,N_Eff/s,R_hat "lp__",-7.3,0.019,0.75,-8.8,-7,-6.7,1.5e+03,1.9e+04,1 I should note that the values displayed in stdout do seem to have a default value of 2 significant figures.

Reproducible Steps:

Please report steps to reproduce the issue. If it's not possible to reproduce, please include a description of how you discovered the issue.

If you have a reproducible example, please include it.

Current Output:

The current output. Knowing what is the current behavior is useful.

Expected Output:

Describe what you expect the output to be. Knowing the correct behavior is also very useful.

Additional Information:

Provide any additional information here.

Current Version:

v2.29.2

mitzimorris avatar Mar 28 '22 20:03 mitzimorris

I think 6 is actually a better default value, but the issue is it is not documented. More discussion here: https://discourse.mc-stan.org/t/cmdstanpy-error-in-fit-summary/26939/13?u=wardbrian

Furthermore, as is pointed out earlier in that thread, std::setprecision does not really align with the natural notion of 'significant figures'

WardBrian avatar Mar 28 '22 20:03 WardBrian