gozwave icon indicating copy to clipboard operation
gozwave copied to clipboard

Added generic description based on device generic/specific code

Open stamp opened this issue 7 years ago • 4 comments

Also fixed a couple of nil pointer exceptions

stamp avatar May 23 '17 21:05 stamp

Codecov Report

Merging #29 into master will decrease coverage by 0.1%. The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   59.83%   59.73%   -0.11%     
==========================================
  Files          36       36              
  Lines        1845     1855      +10     
==========================================
+ Hits         1104     1108       +4     
- Misses        715      721       +6     
  Partials       26       26
Impacted Files Coverage Δ
generators/commandclasses/commandclasses.go 0% <0%> (ø) :arrow_up:
connection.go 66.66% <16.66%> (-0.35%) :arrow_down:
nodes/node.go 23.49% <57.14%> (+1.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c389b24...aa08baf. Read the comment docs.

codecov-io avatar May 23 '17 21:05 codecov-io

~@stamp, are all these commits based on the original PR?~

lukescott avatar Sep 17 '17 17:09 lukescott

This was ages ago :p

It looks like its based on c389b2433780d904b85271ef2dc646ad368dd097

2017-09-17 19:02 GMT+02:00 Luke Scott [email protected]:

@stamp https://github.com/stamp, are all these commits based on the original PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stampzilla/gozwave/pull/29#issuecomment-330062564, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF-DfhnASdWkm9VlCZj9zwx-5M6C9yQks5sjVClgaJpZM4NkT65 .

stamp avatar Oct 02 '17 07:10 stamp

@stamp, ignore me, I responded to the wrong PR.

lukescott avatar Oct 02 '17 18:10 lukescott