mongoaudit icon indicating copy to clipboard operation
mongoaudit copied to clipboard

Exception handling in tests is inconsistent.

Open jacob-meacham opened this issue 8 years ago • 0 comments

I ran into this while debugging #9.

The connection exception, which gives valuable information, is silently swallowed in testers.py#Tester#get_connection. In contrast, tester exceptions themselves aren't caught at all and cause mongoaudit to crash.

Expected behavior: The connection exception is surfaced and testing does not continue If an exception is encountered in a particular test, it is logged and the rest of the tests continue as normal. This allows a user to see the results of the non-crashed tests.

jacob-meacham avatar Feb 12 '17 22:02 jacob-meacham