ecoengine icon indicating copy to clipboard operation
ecoengine copied to clipboard

Placeholder in Input box on Compare Tool

Open ymondal opened this issue 9 years ago • 5 comments

There was a request to change the placeholder text in the URI box of the compare tool. (See below) placeholder

I tried directly setting the CSS placeholder attribute (see above). How is this input box being generated? I'm having trouble finding it in index.js.

ymondal avatar Jul 10 '15 01:07 ymondal

Hmm, Eric split that menu out as a separate repo for reuse and it looks like that's for sure set here: https://github.com/stamen/legend-layer-menu/blob/5e6427e00016812096a7f1c717b3f41025373e3e/src/legend-layer-menu.js#L40

which gets pulled into your code on build by this line: https://github.com/stamen/ecoengine-compare/blob/a21e76ef46780d8cc2619e9628e666225610c4b6/bower.json#L31

We have an ecoengine branch of that, so we could change the copy here: https://github.com/stamen/legend-layer-menu/blob/5e6427e00016812096a7f1c717b3f41025373e3e/src/legend-layer-menu.js#L40

But it might be better for you to fork the repo and change the bower.json to draw from your fork, so you can easily edit in the future.

danrademacher avatar Jul 11 '15 02:07 danrademacher

I dont know if the above pathways that Dan suggests holds true... confirm?

But we talked about going from this: GeoJSON API URL or Keyword to:
e.g., 'Puma concolor' or API URL

mkoo avatar Feb 22 '16 18:02 mkoo

I've tried to update this in the legend-layer-menu module, but it requires updating the bower package which is a process I'm unfamiliar with

https://github.com/stamen/legend-layer-menu

syntagmatic avatar Mar 10 '16 22:03 syntagmatic

@shoeswat @bkg

I ended up merging legend-layer-menu into Compare. It's at the top of index.js right now, but could be moved to its own JavaScript file. The reasons:

  • Legend-layer-menu has Compare-specific code in it, like the placeholder text
  • The process of updating legend-layer-menu isn't well-documented (it's a Bower package)
  • Stamen abandoned work on legend-layer-menu as an independent component, so that repo won't evolve
screen shot 2016-03-18 at 4 00 38 pm

So the legend-layer-menu repo and bower package will be deprecated. Once you pull the changes, you can go ahead and delete or archive Berkeley's version of the repo as well https://github.com/berkeley-gif/legend-layer-menu

syntagmatic avatar Mar 18 '16 23:03 syntagmatic

O yea, I pulled this just to make a change in the text box lol. I think it was requested at some point.

On Fri, Mar 18, 2016 at 7:02 PM, Kai [email protected] wrote:

@shoeswat https://github.com/shoeswat @bkg https://github.com/bkg

I ended up merging legend-layer-menu into Compare. It's at the top of index.js right now, but could be moved to its own JavaScript file. The reasons:

  • Legend-layer-menu has Compare-specific code in it, like the placeholder text
  • The process of updating legend-layer-menu isn't well-documented (it's a Bower package)
  • Stamen abandoned work on legend-layer-menu as an independent component, so that repo won't evolve

[image: screen shot 2016-03-18 at 4 00 38 pm] https://cloud.githubusercontent.com/assets/156229/13894156/45d0ad40-ed22-11e5-82da-b2b4c6287190.png

So the legend-layer-menu repo and bower package will be deprecated. Once you pull the changes, you can go ahead and delete or archive Berkeley's version of the repo as well https://github.com/berkeley-gif/legend-layer-menu

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/stamen/ecoengine/issues/163#issuecomment-198572733

ymondal avatar Mar 18 '16 23:03 ymondal