Splitting out the tunnel directory into a separate module

Open arj03 opened this issue 5 years ago • 2 comments

Trying to add this as a module to ssb-browser I see that a lot of stuff is pulled in (like ssb-master). I was wondering if it would make sense to split out the actual implementation into maybe two modules? ssb-room-server and ssb-room-client?

Sep 12 '20 11:09 arj03

ssb-room-server and ssb-room-client?

Agree. But just to clarify, you're talking specifically about ./tunnel/server.js and ./tunnel/client.js, right? This module ssb-room requires ssb-master because it has all the other things for running the server. In other words, this module is not really a simple SSB plugin, it is bundling a bunch of things. And it should, as you said, be implemented more granularly.

Sep 12 '20 12:09 staltz

Yes, and probably also utils.js into its own module. Still learning here :-)

Sep 12 '20 12:09 arj03